Add LowercaseChar/UppercaseChar, document and add tests #952
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ChrisJefferson
force-pushed
the
case-string
branch
2 times, most recently
from
25de359
to
091ec2d
Compare
ChrisJefferson
force-pushed
the
case-string
branch
from
091ec2d
to
76b5f60
Compare
Current coverage is 48.77% (diff: 100%)@@ master #952 diff @@
==========================================
Files 424 424
Lines 222125 222125
Methods 3430 3430
Messages 0 0
Branches 0 0
==========================================
+ Hits 108238 108341 +103
+ Misses 113887 113784 -103
Partials 0 0
|
|
Looks alright. I would have made the documentation a bit more compact and described all 4 functions in one ManSection. Just as a side-remark: There is also a sophisticated translation to lower and upper case available via unicode strings ( |
| ## | ||
| ## <#GAPDoc Label="LowercaseChar"> | ||
| ## <ManSection> | ||
| ## <Func Name="LowercaseString" Arg='character'/> |
There was a problem hiding this comment.
Should be LowercaseChar
There was a problem hiding this comment.
I've noticed
#W There were LaTeX Warnings:
LaTeX Warning: Label `LowercaseString' multiply defined.
____________________
LaTeX Warning: Label `UppercaseString' multiply defined.
)
____________________
LaTeX Warning: There were multiply-defined labels.
in manual builds (how did we overlook this?) and fixed this in 597bab0
| ## | ||
| ## <#GAPDoc Label="UppercaseChar"> | ||
| ## <ManSection> | ||
| ## <Func Name="UppercaseString" Arg='character'/> |
There was a problem hiding this comment.
Should be UppercaseChar
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Noticed UppercaseString had no documentation, and needed UppercaseChar and LowercaseChar for the case-insensitive tab-completion.
Tick all what applies to this pull request
Write below the description of changes (for the release notes)
Adds functions UppercaseChar and LowercaseChar
Improve documentation for the existing functions UppercaseString and LowercaseString