Don't show tab bar if there's only one tab

[bertob]

We generally don't show tab bars when there's a single one (except in Builder, but that's for reasons which don't really apply to other apps, i.e. that it has an in-app tiling system). The current status quo is not great, because there's a useless second bar at all times, which just says "main" when you create a new model:

As far as I understood, the bar was enabled to make it clearer which diagram you're currently working on, so we'd need to find an alternative place to show the title. Would the window title in the headerbar be an option here, e.g. instead of "Gaphor" in the example above?

Independently from that we should find a better default name than "main". Would something like "Diagram 1" or "Main Diagram" work?

Followup from #1926

[danyeaw]

Thanks @bertob for the suggestion!

I am assuming if there were two tabs open, and you close one, that the tab bar would collapse up, and the diagram would take up the space that the tab bar was using. Is that a correct understanding of how it would work?

[amolenaar]

Yes. That's actually how it worked for 2.12. However, then the diagram name is no longer visible, so you can't know which diagram you're editing.

The header bae shows the name of the model (file name without suffix). If it's a new model it'll show Gaphor.

We could add the diagram name (in this case sequence-diagram – main).

I changed the diagram name to New diagram in #1956.

[bertob]

The header bae shows the name of the model (file name without suffix). If it's a new model it'll show Gaphor.

If the file name is visible below anyway, could we put the diagram name there instead? Alternatively I guess we could try "model name • diagram name" in the title?

[amolenaar]

I'll give it a try. Alternatively we can also show the qualified name (packages + diagram name) in the top bar. We do not have space for that in the tabs, normally.

[amolenaar]

Like this?

Or show the full path?

If the path contains more than 3 elements, I suggest it's shown as Model :: … :: Package :: Diagram name.
For now I used :: as separator. I suppose ﹘, or · would also make a nice candidates.

I think showing the full path adds extra value, since there's no way currently to easily find the opened diagram in the model browser (tree).

[bertob]

I'd go with just the title, the full path gets too messy. If you think it's important an actual pathbar could be an option, but IMO just the name is fine, since the treeview on the left is always accessible. One thing to consider could be visually distinguishing the parent folder in the tree if it's collapsed, so it's easier to find the active item.

[amolenaar]

Just the diagram name looks more clean indeed.

I also created #2005, which provides a Adw.StatusPage when no diagram is opened.

[danyeaw]

Closed by #2004.

[danyeaw]

Thanks @bertob for your suggestion for improvement and @amolenaar for your implementation 👍