Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix socket hang up error during release upload #1986

Merged
merged 1 commit into from Jan 4, 2023
Merged

Conversation

danyeaw
Copy link
Member

@danyeaw danyeaw commented Jan 3, 2023

In run https://github.com/gaphor/gaphor/actions/runs/3824238322/jobs/6520647088 we are getting a socket hangup error when trying to upload final release assets from Windows. We have seen this in the past with Linux as well when we were uploading the sdist and wheel.

This PR replaces use of https://github.com/AButler/upload-release-assets with the gh CLI. Others who have seen this error have reported success with this method.

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bug fix
  • Feature
  • Chore (refactoring, formatting, local variables, other cleanup)
  • Documentation content changes

What is the current behavior?

Intermittent socket hang up errors with CI

Issue Number: N/A

What is the new behavior?

No socket hang up

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@amolenaar
Copy link
Member

This looks a lot nicer.

@amolenaar amolenaar merged commit 40c8dc0 into main Jan 4, 2023
@amolenaar amolenaar deleted the fix-socket-hangup branch January 4, 2023 14:23
@amolenaar amolenaar added this to the 2.15 milestone Jan 4, 2023
@danyeaw danyeaw added the fix A fix for a bug label Jan 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix A fix for a bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants