Fix socket hang up error during release upload #1986
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In run https://github.com/gaphor/gaphor/actions/runs/3824238322/jobs/6520647088 we are getting a socket hangup error when trying to upload final release assets from Windows. We have seen this in the past with Linux as well when we were uploading the sdist and wheel.
This PR replaces use of https://github.com/AButler/upload-release-assets with the gh CLI. Others who have seen this error have reported success with this method.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Intermittent socket hang up errors with CI
Issue Number: N/A
What is the new behavior?
No socket hang up
Does this PR introduce a breaking change?
Other information