Store a null count if parsing XML fails, instead of killing entire run

gapple · Nov 24, 2013 · 3582a32 · 3582a32
1 parent 3c90c66
commit 3582a32
Show file tree

Hide file tree

Showing 2 changed files with 20 additions and 2 deletions.
diff --git a/src/DrupalReleaseDate/DrupalIssueCount.php b/src/DrupalReleaseDate/DrupalIssueCount.php
@@ -203,7 +203,12 @@ public function getCounts($commonParameters, $fetchSet, $viewClass) {
             foreach ($fetchParameters as $parameterKey => $parameterValue) {
                 $query->set($parameterKey, $parameterValue);
             }
-            $results[$fetchKey] = $this->getCount($request, $viewClass);
+            try {
+              $results[$fetchKey] = $this->getCount($request, $viewClass);
+            }
+            catch (DrupalOrgParseException $e) {
+              $results[$fetchKey] = null;
+            }
         }
 
         return $results;
@@ -277,7 +282,13 @@ public function getXmlDocument(\Guzzle\Http\Message\Response $response) {
             );
             $page = str_replace(array_keys($replace), array_values($replace), $page);
 
-            $document = new \SimpleXMLElement($page);
+            try {
+                $document = new \SimpleXMLElement($page);
+            }
+            catch (\Exception $e) {
+                // Throw a better specified Exception.
+                throw new DrupalOrgParseException();
+            }
         }
 
         // Need to register name for default namespace to be able to query anything with xpath

diff --git a/src/DrupalReleaseDate/DrupalOrgParseException.php b/src/DrupalReleaseDate/DrupalOrgParseException.php
@@ -0,0 +1,7 @@
+<?php
+namespace DrupalReleaseDate;
+
+class DrupalOrgParseException extends \RuntimeException
+{
+
+}