Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement] for expired password reset link in sign-up flow #246

Closed
joshbeam opened this issue Jun 5, 2020 · 2 comments · Fixed by #306
Closed

[Enhancement] for expired password reset link in sign-up flow #246

joshbeam opened this issue Jun 5, 2020 · 2 comments · Fixed by #306
Assignees
Labels
enhancement New feature or request UX User Experience
Projects

Comments

@joshbeam
Copy link

joshbeam commented Jun 5, 2020

Steps to reproduce condition where there could be a UX enhancement:

  1. on desktop, visit c0d3.com
  2. sign-up as new user
  3. receive password link in email
  4. wait until link has expired
  5. open link on mobile device
  6. see message "link has expired, request a new password reset"

Suggested enhancement: allow users to request the new password reset from this screen (I navigated to log-in and then to "Forgot your password?" in order to complete the sign up flow after the link initially expired)

Note: I only mentioned the devices (desktop and mobile) because that was how I encountered the issue, but I assume it's the same across a single device

@joshbeam
Copy link
Author

joshbeam commented Jun 5, 2020

The root cause of the expired link portion may be a duplicate of: #244

(I signed up with an uppercase email because of my browser's autofill)

@songz songz added this to To do in C0D3 - UI via automation Jun 9, 2020
@coltonehrman coltonehrman changed the title UX Enhancement for expired password reset link in sign-up flow [UX Enhancement] for expired password reset link in sign-up flow Jun 19, 2020
@coltonehrman coltonehrman changed the title [UX Enhancement] for expired password reset link in sign-up flow [Enhancement] for expired password reset link in sign-up flow Jun 19, 2020
@coltonehrman coltonehrman added enhancement New feature or request UX User Experience labels Jun 19, 2020
@danielthalhuber danielthalhuber self-assigned this Jun 30, 2020
@danielthalhuber danielthalhuber moved this from To do to In progress in C0D3 - UI Jun 30, 2020
@danielthalhuber
Copy link
Contributor

I've outlined a few options below that involve minimal changes to the confirm/[token] component.

In looking at the first 3 options, it occurred to me that the form is no longer necessary if the token/link has expired. Option 4 removes the form and just leaves an Alert wrapped in a NavLink. This might be the better UX option.

Please let me know which (if any) of the the options makes the most sense. Have a different idea? Please let me know.

Option 1

  • Description: add link to existing "Request a new password reset" text

  • Pro: minimal code change (just pass different props to Alert)

  • Con: user might not know to click on "Request a new password reset" text (poor call to action?)

  • Example

    issue-246-option-01

Option 2

  • Description: wrap the Alert in a NavLink

  • Pro: somewhat improved call to action

  • Con: none, unless wrapping an Alert in a NavLink is a discouraged pattern (since Alert already has an internal NavLink implementation)

  • Example:

    issue-246-option-02

Option 3

  • Description: Move the string "Request a new password reset" from the original Alert to a separate, informational Alert

  • Pro: clearer call to action

  • Con: ugly/busy UI

  • Example:

    issue-246-option-03

Option 4

  • Description: wrap the Alert in a NavLink and remove form

  • Pro: clear(est) call to action, no unnecessary UI clutter

  • Con: ???

  • Example:

    issue-246-option-04

danielthalhuber added a commit to danielthalhuber/c0d3-app that referenced this issue Jul 7, 2020
- display error card with button to request new reset token when existing token is expired
- update tests and snapshot
- resolves issue garageScript#246
@songz songz closed this as completed in #306 Jul 8, 2020
C0D3 - UI automation moved this from In progress to Done Jul 8, 2020
anthonykhoa pushed a commit to anthonykhoa/c0d3-app-1 that referenced this issue Nov 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request UX User Experience
Projects
No open projects
C0D3 - UI
  
Done
3 participants