Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

reserved identifier violation #49

Closed
elfring opened this issue Mar 26, 2013 · 2 comments
Closed

reserved identifier violation #49

elfring opened this issue Mar 26, 2013 · 2 comments

Comments

@elfring
Copy link

elfring commented Mar 26, 2013

I would like to point out that identifiers like "_TORQUECONFIG_H_" and "_SIMCOMPONENT_H_" do not fit to the expected naming convention of the C++ language standard.
Would you like to adjust your selection for unique names?

@MichPerry-GG
Copy link
Contributor

I would have no problem with making this change, although there are some higher priority task to resolve first. It will be important to maintain the standard across all the platforms, which will include Objective-CPP. I'd like to hear what others think before we take action.

@ghost
Copy link

ghost commented Mar 27, 2013

It's less of a selection and more of a "how it's always been". There's currently no conflict anywhere but you are free to change them all and submit a pull request and it could be adopted by everyone else.

@doodaddy64
Copy link
Contributor

I think it is agreed that these are nice changes to have. If submitted as a pull request these will be included into the source. I will close this as an "issue" then.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants