This repository has been archived by the owner on Sep 11, 2022. It is now read-only.
Support for responsive pages #33
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for this! I'll take a look at it and merge it in soon. |
ghost
assigned 
|
|
||
| for (var i = 0; i < sticked.length; i++) { | ||
| var s = sticked[i], | ||
| elementTop = s.stickyWrapper.offset().top, | ||
| etse = elementTop - s.topSpacing - extra; | ||
|
|
||
| if (scrollTop <= etse) { | ||
| if (scrollTop <= etse || $window.width() < o.responsiveBreakpoint) { |
There was a problem hiding this comment.
o.responsiveBreakpoint is relying on the defaults object being overwritten whenever this plugin is called: see #104.
If you set responsiveBreakpoint on the sticky object that gets added in methods.init – see code here – you can access it here via s.responsiveBreakpoint and it will reflect that sticky object rather than an accidentally changed global state.
Line 39 can be removed if this is done: o = $.extend(defaults);
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will add support for responsive pages that float columns vertically at certain breakpoints.
By the way, nice plugin! Been really happy with it so far.