[gameclient] Fix broken audio in some cores #59
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The wrong stream type was closed, seemed like a c&p error. This fixes audio playback with the scummvm core.
|
lol, definitely a c/p error. Thanks!!! Got some stuff left, like mouse support, audio underruns and GameStream support, but the end is in sight! |
garbear
pushed a commit
that referenced
this pull request
Jan 9, 2017
[cmake] automate addon.xml version set (Step 2)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@garbear: I was able to track down and fix the missing audio problem in the scummvm core. (mentioned in kodi-game/game.libretro.scummvm#1)
Looks like a c&p error to me, the code closed the wrong stream type.
EDIT: tested on linux, cross checked with bsnes-mercury-balanced (where audio is still working with the patch)
With scummvm working, retroplayer can be considered done (at least for people born in the 80s) :D