Add version property to manifest.json #49
Conversation
|
With version 2021.4.0 this version is required or it will not load the integrations, see the release notes |
|
can we get this merged as we only have another 5 weeks before it stop working on latest version |
|
Any update all my ecowitt stuff is down |
|
@garbled1, could you please merge this tiny change? That is required from HA 2021.6 for a custom component to run. Thanks! |
| @@ -1,6 +1,7 @@ | |||
| { | |||
| "domain": "ecowitt", | |||
| "name": "Ecowitt Weather Station", | |||
| "version": "0.5", | |||
There was a problem hiding this comment.
Should the version string have three version components (major, minor and patch), just to be safe? (Ex: "version": "0.5.0")
https://developers.home-assistant.io/blog/2021/01/29/custom-integration-changes/#versions
The manifest.json file now has added support for a version key. The version should be a string with a major, minor and patch version. For example, "1.0.0".
There was a problem hiding this comment.
@esev, the short answer is no.
Could you please read the page, what you referenced, from the top? You will find the answer why the version key is necessary.
Many components uses nowadays the 2021.X or 2021.X.Y numbering as well.
There was a problem hiding this comment.
I probably phrased my question incorrectly. I edited above to clarify what I meant "version": "0.5.0". Thanks for catching that.
I'm thinking since the HA developers specifically asked for the version string to contain three parts, it might be more future-proof if three parts are used in this PR.
There was a problem hiding this comment.
That is an example only. The whole point is to have version control.
A developer might use other things as well, like 0.1-alfa.
|
+1 for getting this merged plz. |
|
almost monthly check in here for asking if this can be merged plz? home dashboard sitting with broken entities since this went down lol. |
@Joshndroid, I posted a temporary fix a month ago in the issue subject. You can fix it for yourself until this is going to be merged. |
Yeah i did see that. has there been an talk on why this is yet to be merged? |
None, the owner of the repository doesn't seem active. |
|
So what's the Github etiquette here, if the repo owner goes inactive for a long time ? |
@garbled1 probably has a work assignment what makes him to ditch for extended periods the community development. It happened before last Christmas as well, then one day he replied messages, merged PRs, etc. and put a decent effort to make things better, like the new UI based setup flow. Be patien, I am sure when @garbled1 will have some free time, then he will merge the PRs and fix this thing. Until that, just fix it manually, there is no other breaking change to worry about. (I am on 2021.6.2 as I remember. And soon 2021.7.0 will be out. I am not planning to update until I will have enough time to deal with any issues and breaking changes.) Of course, anybody can ask the author to be included in the GitHub repo as an approver. And you can fork the repo as well and start roll your development and updates. But what is the most annoying that people are not looking at other issues, not looking at breaking changes just opening new issues without doing a bit of search. It is not a hard to fix issue. The one in last October/November was neither. Someone found quicly what was wrong and provided a solution. I did a PR later once I tested it. And it was merged when @garbled1 had some time to take care of the development. Just my 5 cents... |
|
Thanks @garbled1! |
Fixes issue #43