fix(secrets): skip already existing secrets while creating (#6099)

* fix(secrets): skip already existing secrets while creating

* improvement: more informative error message on failure

Show user-friendly error message
instead of printing plain HTTP error code and original low-level error message.

* fix: spacing in error renderer

core/src/cloud/api.ts

@@ -42,7 +42,7 @@ import { LogLevel } from "../logger/logger.js"
 import { makeAuthHeader } from "./auth.js"
 import type { StringMap } from "../config/common.js"
 import { styles } from "../logger/styles.js"
-import { RequestError } from "got"
+import { HTTPError, RequestError } from "got"
 import type { Garden } from "../garden.js"
 import type { ApiCommandError } from "../commands/cloud/helpers.js"
 import { enumerate } from "../util/enumerate.js"
@@ -939,13 +939,19 @@ export class CloudApi {
         const res = await this.createSecret(body)
         results.push(res.data)
       } catch (err) {
-        if (!(err instanceof GardenError)) {
+        if (!(err instanceof HTTPError)) {
+          throw err
+        }
+
+        // skip already existing secret and continue the loop
+        if (err.response.statusCode === 409) {
+          errors.push({
+            identifier: name,
+            message: "Secret already exists",
+          })
+        } else {
           throw err
         }
-        errors.push({
-          identifier: name,
-          message: err.message,
-        })
       }
     }
 

core/src/commands/cloud/helpers.ts

@@ -70,7 +70,7 @@ export function handleBulkOperationResult<T>({
           ? `with ID ${e.identifier} `
           : e.identifier === ""
             ? ""
-            : `"${e.identifier} "`
+            : `"${e.identifier}" `
         return `→ ${capitalize(actionVerb)} ${resource} ${identifier}failed with error: ${e.message}`
       })
       .join("\n")