refactor(formatting): improve quoting style of objects to consistent-…

…as-needed

See https://palantir.github.io/tslint/rules/object-literal-key-quotes/

garden-service/src/commands/create/config-templates.ts

@@ -22,7 +22,7 @@ import { ModuleConfig } from "../../config/module"
  * Alternatively, consider co-locating the templates with the plugins.
  */
 export const MODULE_PROVIDER_MAP = {
-  container: "local-kubernetes",
+  "container": "local-kubernetes",
   "google-cloud-function": "local-google-cloud-functions",
   "npm-package": "npm-package",
 }
@@ -91,7 +91,7 @@ export const projectTemplate = (name: string, moduleTypes: ModuleType[]): Projec
 
 export const moduleTemplate = (name: string, type: ModuleType): ModuleTemplate => {
   const moduleTypeTemplate = {
-    container: containerTemplate,
+    "container": containerTemplate,
     "google-cloud-function": googleCloudFunctionTemplate,
     "npm-package": npmPackageTemplate,
   }[type]

garden-service/src/commands/create/project.ts

@@ -41,7 +41,7 @@ const createProjectOptions = {
   "module-dirs": new PathsParameter({
     help: "Relative path to modules directory. Use comma as a separator to specify multiple directories.",
   }),
-  name: new StringParameter({
+  "name": new StringParameter({
     help: "Assigns a custom name to the project (defaults to name of the current directory).",
   }),
 }

garden-service/src/commands/deploy.ts

@@ -30,9 +30,9 @@ const deployArgs = {
 }
 
 const deployOpts = {
-  force: new BooleanParameter({ help: "Force redeploy of service(s)." }),
+  "force": new BooleanParameter({ help: "Force redeploy of service(s)." }),
   "force-build": new BooleanParameter({ help: "Force rebuild of module(s)." }),
-  watch: new BooleanParameter({ help: "Watch for changes in module(s) and auto-deploy.", alias: "w" }),
+  "watch": new BooleanParameter({ help: "Watch for changes in module(s) and auto-deploy.", alias: "w" }),
   "hot-reload": new StringsParameter({
     help: deline`The name(s) of the service(s) to deploy with hot reloading enabled.
       Use comma as a separator to specify multiple services. When this option is used,

garden-service/src/commands/run/module.ts

@@ -39,7 +39,7 @@ const runArgs = {
 const runOpts = {
   // TODO: we could provide specific parameters like this by adding commands for specific modules, via plugins
   //entrypoint: new StringParameter({ help: "Override default entrypoint in module" }),
-  interactive: new BooleanParameter({
+  "interactive": new BooleanParameter({
     help: "Set to false to skip interactive mode and just output the command result.",
     defaultValue: true,
   }),

garden-service/src/commands/run/test.ts

@@ -37,7 +37,7 @@ const runArgs = {
 }
 
 const runOpts = {
-  interactive: new BooleanParameter({
+  "interactive": new BooleanParameter({
     help: "Set to false to skip interactive mode and just output the command result.",
     defaultValue: true,
   }),

garden-service/src/commands/test.ts

@@ -32,13 +32,13 @@ const testArgs = {
 }
 
 const testOpts = {
-  name: new StringOption({
+  "name": new StringOption({
     help: "Only run tests with the specfied name (e.g. unit or integ).",
     alias: "n",
   }),
-  force: new BooleanParameter({ help: "Force re-test of module(s).", alias: "f" }),
+  "force": new BooleanParameter({ help: "Force re-test of module(s).", alias: "f" }),
   "force-build": new BooleanParameter({ help: "Force rebuild of module(s)." }),
-  watch: new BooleanParameter({ help: "Watch for changes in module(s) and auto-test.", alias: "w" }),
+  "watch": new BooleanParameter({ help: "Watch for changes in module(s) and auto-test.", alias: "w" }),
 }
 
 type Args = typeof testArgs

garden-service/src/config-store.ts

@@ -175,7 +175,7 @@ export interface LocalConfig {
 
 const kubernetesLocalConfigSchema = Joi.object()
   .keys({
-    username: joiIdentifier().allow("").optional(),
+    "username": joiIdentifier().allow("").optional(),
     "previous-usernames": Joi.array().items(joiIdentifier()).optional(),
   })
   .meta({ internal: true })

garden-service/test/src/commands/create/project.ts

@@ -52,7 +52,7 @@ describe("CreateProjectCommand", () => {
     const { result } = await cmd.action({
       garden,
       args: { "project-dir": "" },
-      opts: { name: "", "module-dirs": [] },
+      opts: { "name": "", "module-dirs": [] },
     })
     const modules = result.modules.map(m => pick(m, ["name", "type", "path"]))
     const project = pick(result.project, ["name", "path"])
@@ -75,7 +75,7 @@ describe("CreateProjectCommand", () => {
     const { result } = await cmd.action({
       garden,
       args: { "project-dir": "new-project" },
-      opts: { name: "", "module-dirs": [] },
+      opts: { "name": "", "module-dirs": [] },
     })
     expect(pick(result.project, ["name", "path"])).to.eql({
       name: "new-project",
@@ -89,7 +89,7 @@ describe("CreateProjectCommand", () => {
     const { result } = await cmd.action({
       garden,
       args: { "project-dir": "" },
-      opts: { name: "my-project", "module-dirs": [] },
+      opts: { "name": "my-project", "module-dirs": [] },
     })
     expect(pick(result.project, ["name", "path"])).to.eql({
       name: "my-project",
@@ -103,7 +103,7 @@ describe("CreateProjectCommand", () => {
     const { result } = await cmd.action({
       garden,
       args: { "project-dir": "" },
-      opts: { name: "", "module-dirs": ["."] },
+      opts: { "name": "", "module-dirs": ["."] },
     })
     expect(result.modules.map(m => pick(m, ["name", "type", "path"]))).to.eql([
       { type: "container", name: "module-a", path: join(garden.projectRoot, "module-a") },
@@ -117,7 +117,7 @@ describe("CreateProjectCommand", () => {
     const { result } = await cmd.action({
       garden,
       args: { "project-dir": "" },
-      opts: { name: "", "module-dirs": ["module-a", "module-b"] },
+      opts: { "name": "", "module-dirs": ["module-a", "module-b"] },
     })
     expect(result.modules.map(m => pick(m, ["name", "type", "path"]))).to.eql([
       { type: "container", name: "child-module-a", path: join(garden.projectRoot, "module-a", "child-module-a") },
@@ -132,7 +132,7 @@ describe("CreateProjectCommand", () => {
       async () => await cmd.action({
         garden,
         args: { "project-dir": "___" },
-        opts: { name: "", "module-dirs": [] },
+        opts: { "name": "", "module-dirs": [] },
       }),
       "configuration",
     )
@@ -145,7 +145,7 @@ describe("CreateProjectCommand", () => {
       async () => await cmd.action({
         garden,
         args: { "project-dir": "" },
-        opts: { name: "___", "module-dirs": [] },
+        opts: { "name": "___", "module-dirs": [] },
       }),
       "configuration",
     )

garden-service/test/src/commands/deploy.ts

@@ -102,8 +102,8 @@ describe("DeployCommand", () => {
       },
       opts: {
         "hot-reload": undefined,
-        watch: false,
-        force: false,
+        "watch": false,
+        "force": false,
         "force-build": true,
       },
     })
@@ -135,8 +135,8 @@ describe("DeployCommand", () => {
       },
       opts: {
         "hot-reload": undefined,
-        watch: false,
-        force: false,
+        "watch": false,
+        "force": false,
         "force-build": true,
       },
     })

garden-service/test/src/commands/run/module.ts

@@ -29,7 +29,7 @@ describe("RunModuleCommand", () => {
     const { result } = await cmd.action({
       garden,
       args: { module: "run-test", command: [] },
-      opts: { interactive: false, "force-build": false },
+      opts: { "interactive": false, "force-build": false },
     })
 
     const expected: RunResult = {
@@ -55,7 +55,7 @@ describe("RunModuleCommand", () => {
     const { result } = await cmd.action({
       garden,
       args: { module: "run-test", command: ["my", "command"] },
-      opts: { interactive: false, "force-build": false },
+      opts: { "interactive": false, "force-build": false },
     })
 
     const expected: RunResult = {

garden-service/test/src/commands/test.ts

@@ -11,7 +11,7 @@ describe("commands.test", () => {
     const { result } = await command.action({
       garden,
       args: { module: undefined },
-      opts: { name: undefined, force: true, "force-build": true, watch: false },
+      opts: { "name": undefined, "force": true, "force-build": true, "watch": false },
     })
 
     expect(isSubset(taskResultOutputs(result!), {
@@ -46,7 +46,7 @@ describe("commands.test", () => {
     const { result } = await command.action({
       garden,
       args: { module: ["module-a"] },
-      opts: { name: undefined, force: true, "force-build": true, watch: false },
+      opts: { "name": undefined, "force": true, "force-build": true, "watch": false },
     })
 
     expect(isSubset(taskResultOutputs(result!), {

garden-service/test/src/garden.ts

@@ -82,7 +82,7 @@ describe("Garden", () => {
           { name: "test-plugin" },
         ],
         variables: {
-          some: "banana",
+          "some": "banana",
           "service-a-build-command": "OK",
         },
       })

package.json

@@ -47,7 +47,7 @@
     "check-package-lock": "git diff --quiet HEAD -- package-lock.json || (echo 'package-lock.json is dirty!' && exit 1)",
     "clean": "lerna run clean && git clean -X -f",
     "dist": "gulp dist",
-    "fix-format": "node_modules/.bin/tslint -p . --fix && node_modules/.bin/tsfmt -r",
+    "fix-format": "tslint -p . --fix && tsfmt -r",
     "generate-docs": "gulp generate-docs",
     "integ": "lerna run integ",
     "lint": "tslint -p . && tsfmt --verify && gulp check-licenses",

tslint.json

@@ -48,7 +48,7 @@
     "number-literal-format": true,
     "object-literal-key-quotes": [
       true,
-      "as-needed"
+      "consistent-as-needed"
     ],
     "object-literal-shorthand": true,
     "one-variable-per-declaration": true,
@@ -83,4 +83,4 @@
       "check-separator"
     ]
   }
-}
+}