Skip to content

Commit

Permalink
fix(core): missing module configs in dumpConfig response
Browse files Browse the repository at this point in the history
  • Loading branch information
eysi09 committed Feb 5, 2019
1 parent b282a24 commit c8609a2
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 5 deletions.
4 changes: 2 additions & 2 deletions garden-service/src/garden.ts
Original file line number Diff line number Diff line change
Expand Up @@ -711,7 +711,7 @@ export class Garden {
environmentName: this.environment.name,
providers: this.environment.providers,
variables: this.environment.variables,
modules: sortBy(Object.values(this.moduleConfigs), "name"),
moduleConfigs: sortBy(await this.resolveModuleConfigs(), "name"),
}
}

Expand All @@ -722,5 +722,5 @@ export interface ConfigDump {
environmentName: string
providers: Provider[]
variables: PrimitiveMap
modules: ModuleConfig[]
moduleConfigs: ModuleConfig[]
}
5 changes: 2 additions & 3 deletions garden-service/test/src/commands/get/get-config.ts
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
import { expect } from "chai"
import { makeTestGardenA } from "../../../helpers"
import { GetConfigCommand } from "../../../../src/commands/get/get-config"
import { isSubset } from "../../../../src/util/is-subset"
import { sortBy } from "lodash"

describe("GetConfigCommand", () => {
Expand All @@ -24,9 +23,9 @@ describe("GetConfigCommand", () => {
environmentName: garden.environment.name,
providers: garden.environment.providers,
variables: garden.environment.variables,
modules: sortBy(await garden.resolveModuleConfigs(), "name"),
moduleConfigs: sortBy(await garden.resolveModuleConfigs(), "name"),
}

expect(isSubset(config, res.result)).to.be.true
expect(config).to.deep.equal(res.result)
})
})

0 comments on commit c8609a2

Please sign in to comment.