Skip to content

Commit

Permalink
fix: properly wait for k8s deploys to complete
Browse files Browse the repository at this point in the history
* fix: properly wait for k8s sts deploys to complete

We were getting the desired replica count from the status API
response [1] which has the current replica count, not the desired amount.

Desired amount is specified in the spec [2].

1. https://kubernetes.io/docs/reference/kubernetes-api/workload-resources/stateful-set-v1/#StatefulSetStatus
2. https://kubernetes.io/docs/reference/kubernetes-api/workload-resources/stateful-set-v1/#StatefulSetSpec

* fixup! fix: properly wait for k8s sts deploys to complete
  • Loading branch information
Orzelius committed May 24, 2023
1 parent b858375 commit fdb4b6f
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions core/src/plugins/kubernetes/status/workload.ts
Original file line number Diff line number Diff line change
Expand Up @@ -196,7 +196,7 @@ async function getRolloutStatus(workload: Workload) {
const status = <V1StatefulSetStatus>workload.status
const workloadSpec = <Required<V1StatefulSetSpec>>workload.spec

const replicas = status.replicas || 0
const replicas = workloadSpec.replicas || 0
const updated = status.updatedReplicas || 0
const ready = status.readyReplicas || 0

Expand All @@ -221,7 +221,7 @@ async function getRolloutStatus(workload: Workload) {

const desired = deploymentSpec.replicas === undefined ? 1 : deploymentSpec.replicas
const updated = status.updatedReplicas || 0
const replicas = status.replicas || 0
const replicas = deploymentSpec.replicas || 0
const available = status.availableReplicas || 0

if (updated < desired) {
Expand Down

0 comments on commit fdb4b6f

Please sign in to comment.