Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE]: kustomize with helm charts #3289

Closed
hnicke opened this issue Oct 7, 2022 · 5 comments
Closed

[FEATURE]: kustomize with helm charts #3289

hnicke opened this issue Oct 7, 2022 · 5 comments
Labels

Comments

@hnicke
Copy link
Contributor

hnicke commented Oct 7, 2022

Feature Request

Background / Motivation

I'm integrating a 3rd party helm chart into our garden stack.
Its resulting manifests however have a minor flaw and don't suite our needs 100%.
In general I would have three options to address this:

  • supply patch upstream and hope they will incorporate it soon & release a new chart version
  • fork the chart
  • use kustomize

Supplying a patch upstream takes a lot of time and is not guaranteed to be accepted: Some charts stopped accepting PRs to add 'yet another flag'.

Forking a chart has a high maintenance cost and should be considered as last resort only.

It seems to me that at this point in time, the preferred way of solving this is using kustomize:
render helm chart -> run through kustomize -> apply to cluster

What should the user be able to do?

I'd like to use a kustomize overlay for the helm chart module / action.

Why do they want to do this? What problem does it solve?

If I could customize helm charts with garden, I would not neither have to beg upstream to include yet another flag nor take the burden of maintaining a fork if the chart.

Suggested Implementation(s)

I haven't used the kustomize integration of the kubernetes module but I think it could be similar.

How important is this feature for you/your team?

🌵 Not having this feature makes using Garden painful

@vvagaytsev vvagaytsev added priority:medium Medium priority issue or feature triage/accepted labels Oct 10, 2022
@vvagaytsev
Copy link
Collaborator

Thanks for reporting this @hnicke! This looks like an advanced use case. Now we're busy with a more urgent project #3278, so we'll definitely take a look a bit later.

@stale
Copy link

stale bot commented May 21, 2023

This issue has been automatically marked as stale because it hasn't had any activity in 90 days. It will be closed in 14 days if no further activity occurs (e.g. changing labels, comments, commits, etc.). Please feel free to tag a maintainer and ask them to remove the label if you think it doesn't apply. Thank you for submitting this issue and helping make Garden a better product!

@stale stale bot added the stale Label that's automatically set by stalebot. Stale issues get closed after 14 days of inactivity. label May 21, 2023
@vvagaytsev vvagaytsev removed the stale Label that's automatically set by stalebot. Stale issues get closed after 14 days of inactivity. label Jun 19, 2023
@shumailxyz
Copy link
Contributor

More info in #3459

@worldofgeese
Copy link
Contributor

The most important takeaway from #3459 is

In Helm version 3.9.0, Helm adds “a --post-renderer-args flag to support arguments being passed to the post renderer”.

More information on Post Rendering available at Helm's official docs. Post rendering implements native manipulation of Helm charts.

@10ko
Copy link
Member

10ko commented Jan 31, 2024

We don't plan to support this, sorry.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

5 participants