Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE]: support kustomize in helm module #3459

Closed
worldofgeese opened this issue Dec 16, 2022 · 4 comments
Closed

[FEATURE]: support kustomize in helm module #3459

worldofgeese opened this issue Dec 16, 2022 · 4 comments

Comments

@worldofgeese
Copy link
Contributor

worldofgeese commented Dec 16, 2022

Feature Request

Garden's kubernetes module supports Kustomize. Let's port this support to Garden's helm module using Helm's post rendering feature.

Background / Motivation

I was writing an article for Garden's blog on Helm charts and thought wow one of Helm's most powerful features, post rendering, would be a huge win in our push to catering to DevOps Engineers and platform teams that work with Kubernetes every day.

What should the user be able to do?

At first, anything users of the kubernetes module can do with its support for kustomize. Later, pass to Helm "any executable that accepts rendered Kubernetes manifests on STDIN and returns valid Kubernetes manifests on STDOUT"1.

Why do they want to do this? What problem does it solve?

This feature would help bring feature parity to both kubernetes and helm modules and eliminate cases of, "we support Helm but..." and other gotchas when SREs, DevOps Engineers, and Platform Engineers turn to use these tools. Increasing coverage of support for the underlying technologies behind these modules reduces frustration and works as a user expects. Users typically expect everything works when support is advertised: see CockroachDB's continued march toward syntax-parity with Postgres for an example.

Suggested Implementation(s)

Expose functionality exactly as the kubernetes module. The backend would call Kustomize as its post-render executable. Allows arguments as the kubernetes module.

How important is this feature for you/your team?

🌹 It’s a nice to have, but nice things are nice 🙂

Footnotes

  1. https://helm.sh/docs/topics/advanced/#usage

@worldofgeese
Copy link
Contributor Author

worldofgeese commented Dec 17, 2022

In Helm version 3.9.0, Helm adds “a --post-renderer-args flag to support arguments being passed to the post renderer”.

@hnicke
Copy link
Contributor

hnicke commented Dec 19, 2022

See also #3289.

@stale
Copy link

stale bot commented Jun 18, 2023

This issue has been automatically marked as stale because it hasn't had any activity in 90 days. It will be closed in 14 days if no further activity occurs (e.g. changing labels, comments, commits, etc.). Please feel free to tag a maintainer and ask them to remove the label if you think it doesn't apply. Thank you for submitting this issue and helping make Garden a better product!

@stale stale bot added the stale Label that's automatically set by stalebot. Stale issues get closed after 14 days of inactivity. label Jun 18, 2023
@vvagaytsev vvagaytsev removed the stale Label that's automatically set by stalebot. Stale issues get closed after 14 days of inactivity. label Jun 19, 2023
@vvagaytsev
Copy link
Collaborator

This duplicates #3289.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants