Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

0.13: [Bug]: Get Actions errors out if any action is disabled #4937

Closed
mattpolzin opened this issue Aug 11, 2023 · 1 comment · Fixed by #5203
Closed

0.13: [Bug]: Get Actions errors out if any action is disabled #4937

mattpolzin opened this issue Aug 11, 2023 · 1 comment · Fixed by #5203
Labels
0.13 bug devex Developer experience and ease of use.

Comments

@mattpolzin
Copy link
Contributor

mattpolzin commented Aug 11, 2023

Garden Bonsai (0.13) Bug

Current Behavior

Create a set of circumstances where one of the actions in a project will resolve to disabled: true and then run garden get actions --detail. The result will be an error like

me: ~/staging/repo (garden-bonsai) $ garden get actions --detail --env dns
Get Actions 📖 

Garden v0.13 (Bonsai) is a major release with significant changes. Please help us improve it by reporting any issues/bugs here:
https://go.garden.io/report-bonsai
→ Run garden util hide-warning 0.13-bonsai to disable this warning.
ℹ garden               → Running in Garden environment dev
ℹ providers            → Getting status...
✔ providers            → Cached (took 1.9 sec)
ℹ providers            → Run with --force-refresh to force a refresh of provider statuses.
ℹ graph                → Resolving actions and modules...
✔ graph                → Done (took 39.4 sec)


Deploy type=container name=something-or-other is disabled.

Expected behavior

I expect garden get actions --detail to retrieve details about all actions, or at least all enabled actions, without erroring out because it discovers some actions are disabled.

Reproducible example

Workaround

Make sure every single action is enabled I guess?

Suggested solution(s)

Additional context

Your environment

  • OS: macOS 13.4.1 (c)
  • How I'm running Kubernetes: AKS (Azure)

garden version: 0.13.10-edge-bonsai-a65f2c49d

@vvagaytsev vvagaytsev added the devex Developer experience and ease of use. label Aug 14, 2023
@shumailxyz shumailxyz added the bug label Aug 16, 2023
@shumailxyz
Copy link
Contributor

I think this is likely coming from

https://github.com/garden-io/garden/blob/main/core/src/graph/config-graph.ts#L191-L196

To add some more context, --detail flag also goes through each action to list down the dependents of each action which in return calls getActionByKind and there it fails if an action is disabled.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0.13 bug devex Developer experience and ease of use.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants