Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: allow listing disabled actions in get actions cmd #5203

Merged
merged 1 commit into from
Oct 7, 2023

Conversation

shumailxyz
Copy link
Contributor

@shumailxyz shumailxyz commented Oct 6, 2023

What this PR does / why we need it:
get actions --detail command basically doesn't work in case one of the actions is disabled. Ran into this multiple times and it's so annoying. With this PR, it stops throwing error for get actions, if an action is disabled.

Which issue(s) this PR fixes:

Fixes #4937

Special notes for your reviewer:

@shumailxyz shumailxyz requested a review from a team October 6, 2023 16:19
Copy link
Collaborator

@eysi09 eysi09 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@eysi09 eysi09 added this pull request to the merge queue Oct 7, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Oct 7, 2023
@eysi09 eysi09 added this pull request to the merge queue Oct 7, 2023
Merged via the queue into main with commit eb316b1 Oct 7, 2023
42 checks passed
@eysi09 eysi09 deleted the fix-get-actions-disabled-actions branch October 7, 2023 12:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

0.13: [Bug]: Get Actions errors out if any action is disabled
2 participants