fix(remote-building): use "Recreate" strategy garden-util (kaniko) and garden-buildkit deployments #5125
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TimBeyer
reviewed
Sep 21, 2023
…d garden-buildkit deployments We need to use the "Recreate" strategy for garden-util and garden-buildkit deployments, because otherwise we can run into issues where multiple Pods are running at the same time Also with the latest main I often get an error "Could not find a running Pod in Deployment garden-buildkit in namespace xxx" – this change fixes that too.
stefreak
force-pushed
the
fix-remote-building
branch
from
3bd6771
to
3659071
Compare
TimBeyer
changed the title
TimBeyer
approved these changes
Sep 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We need to use the "Recreate" strategy for garden-util and garden-buildkit deployments, because
otherwise we can run into issues where multiple Pods are running at the same time
Also with the latest main I often get an error "Could not find a running Pod in Deployment garden-buildkit in namespace xxx" – this change fixes that too.
What this PR does / why we need it:
Which issue(s) this PR fixes:
e.g. Fixes #2570
Special notes for your reviewer:
The remote tests are covering this issue, but they are currently disabled in CI. Enabling them is out of scope for this PR, but will be addressed in #5103