test: enable remote tests #5103
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stefreak
force-pushed
the
enable-remote-tests
branch
from
bd38b85
to
019f6fe
Compare
stefreak
commented
Sep 20, 2023
stefreak
commented
Sep 25, 2023
stefreak
commented
Sep 26, 2023
TimBeyer
reviewed
Sep 29, 2023
…til pod Before this fix we sometimes synced to or from the old Pod Co-authored-by: Mikael Högqvist Tabor <mkhq@users.noreply.github.com>
…ests This allows google artifact registry access in the garden-ci project. Using the service account impersonation has the benefit that we can allow any google group to impersonate this service account, so we do not need to manage access manually: This only works because we granted the google group "dev@garden.io" permission to impersonate this service account with the following command: `gcloud iam service-accounts add-iam-policy-binding gar-serviceaccount@garden-ci.iam.gserviceaccount.com --member=group:dev@garden.io --role=roles/iam.serviceAccountTokenCreator` We could extend this in the future to allow access to the CI cluster in the same way, without the need to manage users manually. Co-authored-by: twelvemo <anna@garden.io>
Co-authored-by: Steffen Neubauer <stefreak@users.noreply.github.com>
…loy of util pod" This reverts commit c34b8ec.
Co-authored-by: Steffen Neubauer <stefreak@users.noreply.github.com>
co-authored-by: mikael <mikael@garden.io>
Co-authored-by: Steffen Neubauer <stefreak@users.noreply.github.com>
mkhq
force-pushed
the
enable-remote-tests
branch
from
7f5e543
to
da29a1c
Compare
mkhq
force-pushed
the
enable-remote-tests
branch
from
06c95a9
to
b68e936
Compare
- move error handling of impersonated client to point of creation Co-authored-by: Steffen Neubauer <stefreak@users.noreply.github.com>
mkhq
previously approved these changes
Oct 2, 2023
mkhq
approved these changes
Oct 2, 2023
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
We enable the remote tests to run in CI. This includes integration tests that are requiring some form of remote service access. In order to get these tests to work again, we have had to:
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
There are a couple of test suites that are disabled:
Tests in the disabled suites have been passing locally when we have been able to ensure there is no concurrent access to the registry. We plan to fix issues with concurrent and slow running tests in an upcoming PR. The affected tests are mainly related to local-mode and in-cluster building with kaniko and buildkit.