fix(k8s): ensure patchResources can patch namespace #5334
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eysi09
force-pushed
the
fix-patch-namespace-2
branch
from
cfcbf2e
to
12664d7
Compare
When applying K8s resources, we create a ConfigMap with metadata about the resources for faster lookup. This metadata includes the resource namespace among other things. Before this fix, we'd create the ConfigMap before applying the resource patch which meant that if you patched the actual resource namespace, Garden wouldn't store that information. Later when looking up the status of the resource, Garden would use the data from the ConfigMap and basically look for the resource in the wrong namespace and return status "not-ready" (when in fact the resource could be ready, just in a different namespace).
eysi09
force-pushed
the
fix-patch-namespace-2
branch
from
12664d7
to
3cabc17
Compare
eysi09
commented
Nov 2, 2023
| @@ -177,6 +165,16 @@ export async function getManifests({ | |||
| ) | |||
| } | |||
|
|
|||
| if (action.kind === "Deploy") { | |||
| // Add metadata ConfigMap to aid quick status check | |||
| const metadataManifest = getMetadataManifest(action, defaultNamespace, patchedManifests) | |||
There was a problem hiding this comment.
The fix here is that now we're getting the metadata for the patched manifests.
twelvemo
approved these changes
Nov 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
When applying K8s resources, we create a ConfigMap with metadata about the resources for faster lookup.
This metadata includes the resource namespace among other things.
Before this fix, we'd create the ConfigMap before applying the resource patch which meant that if you patched the actual resource namespace, Garden wouldn't store that information.
Later when looking up the status of the resource, Garden would use the data from the ConfigMap and basically look for the resource in the wrong namespace and return status "not-ready" (when in fact the resource could be ready, just in a different namespace).
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
waitForResourcesfunction return the correct status?