Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(k8s): ensure patchResources can patch namespace #5334

Merged
merged 1 commit into from
Nov 2, 2023

Commits on Nov 2, 2023

  1. fix(k8s): ensure patchResources can patch namespace

    When applying K8s resources, we create a ConfigMap with metadata about
    the resources for faster lookup.
    
    This metadata includes the resource namespace among other things.
    
    Before this fix, we'd create the ConfigMap before applying the resource
    patch which meant that if you patched the actual resource namespace,
    Garden wouldn't store that information.
    
    Later when looking up the status of the resource, Garden would use the
    data from the ConfigMap and basically look for the resource in the
    wrong namespace and return status "not-ready" (when in fact the resource
    could be ready, just in a different namespace).
    eysi09 committed Nov 2, 2023
    Configuration menu
    Copy the full SHA
    3cabc17 View commit details
    Browse the repository at this point in the history