feat: add analytics #819
Merged
feat: add analytics #819
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
10ko
force-pushed
the
feat-add-analytics
branch
3 times, most recently
from
c4b2c7f
to
45016f4
Compare
|
@edvald I requested you as a reviewer since you have more experience with Amplitude and these things in general. |
edvald
requested changes
Jun 13, 2019
10ko
force-pushed
the
feat-add-analytics
branch
5 times, most recently
from
cdc32e3
to
bdd6eb7
Compare
|
Thanks @edvald, addressed all your comments and refactored quite a bit. ✌️ |
edvald
previously requested changes
Jun 13, 2019
This feature add the Analytics class to manage opt-in/opt-out and tracking of events happening within the CLI and the Dashboard. Introduces also the command `garden update-analytics` to update your preferences.
edvald
force-pushed
the
feat-add-analytics
branch
from
bdf1201
to
b72dcc9
Compare
eysi09
reviewed
Jun 13, 2019
docs/reference/commands.md
Outdated
| To help us make Garden better you can opt in to the collection of usage data. | ||
| We make sure all the data collected is anonymized and stripped of sensitive | ||
| information. We collect data about which commands are run, what tasks they trigger, | ||
| the API calls are made to your local Garden server, as well as some info |
There was a problem hiding this comment.
"That" (or similar) missing in: "the API calls are made to your local..."
There was a problem hiding this comment.
I also would've put a comma in: "To help us make Garden better, you can opt in to the collection of usage data." After "better" that is. But I guess that's a style preference.
eysi09
requested changes
Jun 13, 2019
docs/reference/commands.md
Outdated
| To help us make Garden better you can opt in to the collection of usage data. | ||
| We make sure all the data collected is anonymized and stripped of sensitive | ||
| information. We collect data about which commands are run, what tasks they trigger, | ||
| the API calls are made to your local Garden server, as well as some info |
There was a problem hiding this comment.
I also would've put a comma in: "To help us make Garden better, you can opt in to the collection of usage data." After "better" that is. But I guess that's a style preference.
edvald
force-pushed
the
feat-add-analytics
branch
3 times, most recently
from
44f53ae
to
ec9f7b1
Compare
eysi09
approved these changes
Jun 13, 2019
edvald
force-pushed
the
feat-add-analytics
branch
from
ec9f7b1
to
5e0c99f
Compare
edvald
force-pushed
the
feat-add-analytics
branch
from
5e0c99f
to
cbd20f6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.