-
Notifications
You must be signed in to change notification settings - Fork 268
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add analytics #819
feat: add analytics #819
Conversation
c4b2c7f
to
45016f4
Compare
@edvald I requested you as a reviewer since you have more experience with Amplitude and these things in general. |
cdc32e3
to
bdd6eb7
Compare
Thanks @edvald, addressed all your comments and refactored quite a bit. ✌️ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mostly minor comments and doc issues, otherwise 👍👍
This feature add the Analytics class to manage opt-in/opt-out and tracking of events happening within the CLI and the Dashboard. Introduces also the command `garden update-analytics` to update your preferences.
bdf1201
to
b72dcc9
Compare
docs/reference/commands.md
Outdated
To help us make Garden better you can opt in to the collection of usage data. | ||
We make sure all the data collected is anonymized and stripped of sensitive | ||
information. We collect data about which commands are run, what tasks they trigger, | ||
the API calls are made to your local Garden server, as well as some info |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"That" (or similar) missing in: "the API calls are made to your local..."
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I also would've put a comma in: "To help us make Garden better, you can opt in to the collection of usage data." After "better" that is. But I guess that's a style preference.
docs/reference/commands.md
Outdated
To help us make Garden better you can opt in to the collection of usage data. | ||
We make sure all the data collected is anonymized and stripped of sensitive | ||
information. We collect data about which commands are run, what tasks they trigger, | ||
the API calls are made to your local Garden server, as well as some info |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I also would've put a comma in: "To help us make Garden better, you can opt in to the collection of usage data." After "better" that is. But I guess that's a style preference.
44f53ae
to
ec9f7b1
Compare
ec9f7b1
to
5e0c99f
Compare
5e0c99f
to
cbd20f6
Compare
No description provided.