feat: add basic support for helm charts #118
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Found a bug after rebase-ing, looking into it |
edvald
changed the title
edvald
changed the title
|
This npm package-lock issue will be the end of me |
Note: This initial implementation doesn't use helm for installing charts, just for fetching and rendering the manifests. We'll change that in following steps, eventually removing the specs module.
thsig
approved these changes
Jun 14, 2018
| } | ||
|
|
||
| await apiPostOrPut(coreApi(context).namespaces(ns).configmaps, resultKey, body) | ||
| try { |
There was a problem hiding this comment.
Maybe it would be cleaner to abstract this repeated try/catch pattern around the coreApi calls with something similar to the old apiPostOrPut function that was removed in this commit?
8ccd9a1#diff-1300351cb8f4f405710841426a313b36L37
Maybe something like await coreApiRequest(tryFn, catchFn, statusCode)?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implementation note: We're not actually using helm to perform the
install, since it proved unreliable and opaque. We instead use helm
to render the templates and provide an array of specs that we feed
to kubectl apply. This also avoids the need for installing tiller,
which will be removed in Helm 3 either way. We may reconsider this
approach when Helm 3 is out and stable.