feat: add persistentvolumeclaim module type and volumes for containers #1615
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
edvald
force-pushed
the
pvc
branch
2 times, most recently
from
9a5f975
to
ec9259a
Compare
This makes it possible to mount persistent volumes in container modules, including in tasks and tests. With the right storage classes in place, you can even share volumes between container services, tasks and tests. These volumes can of course also be referenced in `kubernetes` and `helm` modules. See the added section to the container modules guide for details on how to use the new features. As a small bonus, in order to be able to use the upstream PersistentVolumeClaim schema, I've added a `joi.customObject().jsonSchema()` type, which allows us weave JSON schemas into our existing Joi schemas. My hope is that we can gradually get rid of most usages of Joi schemas, at least in our plugin APIs.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This makes it possible to mount persistent volumes in container modules,
including in tasks and tests. With the right storage classes in place,
you can even share volumes between container services, tasks and tests.
These volumes can of course also be referenced in
kubernetesandhelmmodules.See the added section to the container modules guide for details on
how to use the new features.
As a small bonus, in order to be able to use the upstream
PersistentVolumeClaim schema, I've added a
joi.customObject().jsonSchema()type, which allows us weave JSONschemas into our existing Joi schemas. My hope is that we can gradually
get rid of most usages of Joi schemas, at least in our plugin APIs.
Which issue(s) this PR fixes:
Closes #1607