Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: update ToC layout #1633

Merged
merged 1 commit into from
Feb 25, 2020
Merged

docs: update ToC layout #1633

merged 1 commit into from
Feb 25, 2020

Conversation

edvald
Copy link
Collaborator

@edvald edvald commented Feb 21, 2020

What this PR does / why we need it:

This makes the table of contents in our docs site more readable (and attractive), and certain documentation sections more prominent.

@edvald edvald force-pushed the docs-toc-update branch 2 times, most recently from 2487299 to d323391 Compare February 22, 2020 17:00
docs/README.md Outdated
* [Remote Kubernetes](./guides/remote-kubernetes.md)
* [Terraform](./guides/terraform.md)
* [Variables and templating](./guides/variables-and-templating.md)
* [Advanced](./guides/advanced/README.md)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would it make sense to also have the Advanced section top level? So Guides and Advanced Guides. It's a little hidden like this. I also don't think that Remote Sources should be considered advanced, but perhaps Terraform should.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's all debatable. I think remote sources are for sure advanced, but maybe Terraform also. That's all a matter of perspective 🤷‍♂️

Matters less, of course, if we move the advanced section higher. I do like having this distinction though.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah I definitely agree we should have an Advanced section. And it can of course be debatable what we put in there. But if it's top level it's at least visible. Do you think we'd have too many top-level sections if we put Advanced Guides there as well?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I moved them to a top-level Advanced section, and moved Terraform there too.

docs/README.md Show resolved Hide resolved
garden-service/src/docs/table-of-contents.ts Show resolved Hide resolved
garden-service/src/docs/table-of-contents.ts Show resolved Hide resolved
@edvald edvald merged commit 1ffcb98 into master Feb 25, 2020
@edvald edvald deleted the docs-toc-update branch February 25, 2020 18:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants