Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(cli): create command didn't work from release build #1639

Merged
merged 1 commit into from
Feb 24, 2020

Conversation

edvald
Copy link
Collaborator

@edvald edvald commented Feb 24, 2020

Ugh, this is a straight-up facepalm. We really need to work out how
to run our test suite with the release binary.

@eysi09
Copy link
Collaborator

eysi09 commented Feb 24, 2020

We could also add this command to the bin/test_release.sh script. I know it's not optimal to only catch these just before a release, but I suppose it's better than not catching them at all.

Ugh, this is a straight-up facepalm. We really need to work out how
to run our test suite with the release binary.
@edvald edvald merged commit 5180604 into master Feb 24, 2020
@edvald edvald deleted the fix-create-release branch February 24, 2020 22:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants