refactor: remove dependency on watchman #192
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This PR resolves #101. |
edvald
reviewed
Jul 3, 2018
src/watch.ts
Outdated
| res(result) | ||
| }) | ||
| this.watcher = watch(projectRoot, { | ||
| ignored: /(^|[\/\\])\../, // just ignore dotfiles for now |
There was a problem hiding this comment.
Does this implicitly ignore files in .gitignore? If not we should probably add that, and could add .gardenignore support along the way (which would work the same).
src/watch.ts
Outdated
| this.ctx.invalidateCacheUp(cacheContext) | ||
|
|
||
| this.ctx.invalidateCache(cacheContext) | ||
| this.ctx.invalidateCacheDown(cacheContext) |
There was a problem hiding this comment.
Hmm, I don't think you want to call all three of these?
There was a problem hiding this comment.
Ah, this is a leftover from when I was debugging that I seem to have forgotten to clean up (same for the other two below, #192 (comment) & #192 (comment)).
I'll fix these now.
src/watch.ts
Outdated
| (relPath) => f.name.startsWith(relPath)) | ||
| if (module.path.startsWith(dirPath)) { | ||
| // at least one module's root dir was removed | ||
| await this.invalidateCachedForAll() |
src/watch.ts
Outdated
| const changedModule = modules.find(m => filePath.startsWith(m.path)) || null | ||
|
|
||
| if (changedModule) { | ||
| await this.invalidateCachedForAll() |
edvald
approved these changes
Jul 9, 2018
edvald
changed the title
Instead of using FB's watchman library to monitor FS changes in watch commands, we now use the pure-JS library chokidar.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of using FB's watchman library to monitor FS changes in watch
commands, we now use the pure-JS library chokidar.