feat(k8s): use pod spec fields in tasks and tests #2165
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thsig
force-pushed
the
pod-runner-config-improvements
branch
from
9dffb91
to
ae82b41
Compare
edvald
reviewed
Jan 5, 2021
| @@ -41,7 +41,7 @@ resources: {} | |||
| # cpu: 100m | |||
| # memory: 128Mi | |||
|
|
|||
| nodeSelector: {} | |||
| nodeSelector: { diskType: ssd } | |||
There was a problem hiding this comment.
This may be why the tests are failing. The Pod cannot be scheduled.
|
This all seems to make sense @thsig, but there is that test timing out. I had a suspicion as to why, see comment above. |
This function was getting too long to easily read.
thsig
force-pushed
the
pod-runner-config-improvements
branch
2 times, most recently
from
272a9de
to
1bd446c
Compare
For `helm` and `kubernetes` modules, we now use most pod spec fields from the service resource when running the task/test (based on a fixed whitelist of pod spec fields). This allows tasks/tests to e.g. use custom service accounts, node selectors etc.
thsig
force-pushed
the
pod-runner-config-improvements
branch
from
1bd446c
to
e9c1cc7
Compare
|
This should be good to go now. I've replaced the blacklist with a whitelist of pod spec fields, and it also looks like the tests are now fine (since I used a different field than |
edvald
approved these changes
Feb 3, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
For
helmandkubernetesmodules, we now use all pod spec fields from the service resource when running the task/test (excluding a fixed blacklist of pod spec fields).This allows tasks/tests to e.g. use custom service accounts, node selectors etc.
Also refactored / broke up the
runAndCopyfunction.Which issue(s) this PR fixes:
Fixes #2118.
Special notes for reviewer:
What do we think of the blacklist as it is here? Do we want to add/remove any fields?