improvement(logs): run and test commands error handling #3309
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vvagaytsev
force-pushed
the
improvement/run-command-error-handling
branch
from
c332335
to
3287458
Compare
Report exit code for all types of errors if possible.
vvagaytsev
force-pushed
the
improvement/run-command-error-handling
branch
3 times, most recently
from
6211fe8
to
4155a2c
Compare
Otherwise, some errors might be silently swallowed.
Orzelius
approved these changes
Oct 20, 2022
This was referenced Jan 1, 2024
This was referenced Mar 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This PR unifies error handling for
garden runandgarden testcommands when running those with and without artifacts.Which issue(s) this PR fixes:
Partially resolves #3297
Special notes for your reviewer: