Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: set default timeouts #4066

Merged
merged 30 commits into from May 12, 2023
Merged

chore: set default timeouts #4066

merged 30 commits into from May 12, 2023

Commits on May 11, 2023

  1. refactor: move constant defaultBuildTimeout to constants.ts

    @vvagaytsev
    vvagaytsev committed May 11, 2023
    Configuration menu
    Copy the full SHA
    7a08e4c View commit details
    Browse the repository at this point in the history

  2. refactor: rename timeout constants for clarity 

    Also use the same case-style.
    @vvagaytsev
    vvagaytsev committed May 11, 2023
    Configuration menu
    Copy the full SHA
    b10a595 View commit details
    Browse the repository at this point in the history

  3. chore: set default build action timeout in joi schema

    @vvagaytsev
    vvagaytsev committed May 11, 2023
    Configuration menu
    Copy the full SHA
    a9afc8a View commit details
    Browse the repository at this point in the history

  4. chore: set default run action timeout in joi schema

    @vvagaytsev
    vvagaytsev committed May 11, 2023
    Configuration menu
    Copy the full SHA
    9c8dc11 View commit details
    Browse the repository at this point in the history

  5. chore: set default test action timeout in joi schema

    @vvagaytsev
    vvagaytsev committed May 11, 2023
    Configuration menu
    Copy the full SHA
    3df5562 View commit details
    Browse the repository at this point in the history

  6. chore: change default run and test action timeouts to 600s 

    BREAKING CHANGE

This can affect existing pipelines with long-running tests and tasks. The old value was 60000 seconds.
    @vvagaytsev
    vvagaytsev committed May 11, 2023
    Configuration menu
    Copy the full SHA
    8c81431 View commit details
    Browse the repository at this point in the history

  7. chore: remove duplicate constant 

    Use `DEFAULT_RUN_TIMEOUT_SEC` everywhere.
    @vvagaytsev
    vvagaytsev committed May 11, 2023
    Configuration menu
    Copy the full SHA
    0b99f31 View commit details
    Browse the repository at this point in the history

  8. docs: re-generated docs

    @vvagaytsev
    vvagaytsev committed May 11, 2023
    Configuration menu
    Copy the full SHA
    2e3f470 View commit details
    Browse the repository at this point in the history

  9. refactor: extract named constant

    @vvagaytsev
    vvagaytsev committed May 11, 2023
    Configuration menu
    Copy the full SHA
    03ac5ea View commit details
    Browse the repository at this point in the history

  10. chore: default timeout value for module-based tasks and tests

    @vvagaytsev
    vvagaytsev committed May 11, 2023
    Configuration menu
    Copy the full SHA
    cac6955 View commit details
    Browse the repository at this point in the history

  11. chore: set min timeout value for module builds

    @vvagaytsev
    vvagaytsev committed May 11, 2023
    Configuration menu
    Copy the full SHA
    d754f43 View commit details
    Browse the repository at this point in the history

  12. refactor: non-nullable timeout in BaseTestSpec

    @vvagaytsev
    vvagaytsev committed May 11, 2023
    Configuration menu
    Copy the full SHA
    41caeb7 View commit details
    Browse the repository at this point in the history

  13. refactor: non-nullable timeout in BaseTaskSpec

    @vvagaytsev
    vvagaytsev committed May 11, 2023
    Configuration menu
    Copy the full SHA
    f35b1b4 View commit details
    Browse the repository at this point in the history

  14. chore: replace DEFAULT_BUILD_TIMEOUT by DEFAULT_BUILD_TIMEOUT_SEC 

    Constant `DEFAULT_BUILD_TIMEOUT` was used only in tests, and was a duplicate of `DEFAULT_BUILD_TIMEOUT_SEC`.
    @vvagaytsev
    vvagaytsev committed May 11, 2023
    Configuration menu
    Copy the full SHA
    f375f77 View commit details
    Browse the repository at this point in the history

  15. test: fix module version assertions 

    The version was changed because the `timeout` field was set in the config.
    @vvagaytsev
    vvagaytsev committed May 11, 2023
    Configuration menu
    Copy the full SHA
    71979cd View commit details
    Browse the repository at this point in the history

  16. test: fix test assertions 

    Now timeout is always defined in the root-level config and in each run/task spec.
    @vvagaytsev
    vvagaytsev committed May 11, 2023
    Configuration menu
    Copy the full SHA
    87efd53 View commit details
    Browse the repository at this point in the history

  17. chore: require integer as a k8s deployment timeout

    @vvagaytsev
    vvagaytsev committed May 11, 2023
    Configuration menu
    Copy the full SHA
    dd916c7 View commit details
    Browse the repository at this point in the history

  18. refactor: non-nullable timeout in BaseBuildSpec

    @vvagaytsev
    vvagaytsev committed May 11, 2023
    Configuration menu
    Copy the full SHA
    9869b0e View commit details
    Browse the repository at this point in the history

  19. style: linting

    @vvagaytsev
    vvagaytsev committed May 11, 2023
    Configuration menu
    Copy the full SHA
    e5e9266 View commit details
    Browse the repository at this point in the history

  20. chore: use default Run action timeout (similarly to Test action) 

    Use the same set pattern as in the Test action. The non-null timeout value is set in the downstream functions, so there is no harm.

All action are planned to have non-null timeout, so the default value here will be omitted in the later commits.
    @vvagaytsev
    vvagaytsev committed May 11, 2023
    Configuration menu
    Copy the full SHA
    4a80859 View commit details
    Browse the repository at this point in the history

  21. chore: non-optional timeout in BaseRunParams 

    It's always set in the caller-side functions.
    @vvagaytsev
    vvagaytsev committed May 11, 2023
    Configuration menu
    Copy the full SHA
    93af1ac View commit details
    Browse the repository at this point in the history

  22. chore: added some TODOs

    @vvagaytsev
    vvagaytsev committed May 11, 2023
    Configuration menu
    Copy the full SHA
    4cffa52 View commit details
    Browse the repository at this point in the history

  23. chore: set default timeout for exec service

    @vvagaytsev
    vvagaytsev committed May 11, 2023
    Configuration menu
    Copy the full SHA
    8665c28 View commit details
    Browse the repository at this point in the history

  24. chore: set default timeout for exec Deploy action

    @vvagaytsev
    vvagaytsev committed May 11, 2023
    Configuration menu
    Copy the full SHA
    72208a2 View commit details
    Browse the repository at this point in the history

  25. refactor: make timeout nonnullable in KubernetesTypeCommonDeploySpec

    @vvagaytsev
    vvagaytsev committed May 11, 2023
    Configuration menu
    Copy the full SHA
    e032d4f View commit details
    Browse the repository at this point in the history

  26. refactor: add optional timeout field in BaseActionConfig

    @vvagaytsev
    vvagaytsev committed May 11, 2023
    Configuration menu
    Copy the full SHA
    243a4a6 View commit details
    Browse the repository at this point in the history

  27. chore: fix typo

    @vvagaytsev
    vvagaytsev committed May 11, 2023
    Configuration menu
    Copy the full SHA
    61e9f50 View commit details
    Browse the repository at this point in the history

  28. refactor: shrink default build timeout to 600 sec

    @vvagaytsev
    vvagaytsev committed May 11, 2023
    Configuration menu
    Copy the full SHA
    0613f4c View commit details
    Browse the repository at this point in the history

  29. test: fix test assertions

    @vvagaytsev
    vvagaytsev committed May 11, 2023
    Configuration menu
    Copy the full SHA
    e0f8515 View commit details
    Browse the repository at this point in the history

  30. chore: make timeout required in runBaseParams 

    Non-optional value  is always set from outside.
    @vvagaytsev
    vvagaytsev committed May 11, 2023
    Configuration menu
    Copy the full SHA
    f7c1cbf View commit details
    Browse the repository at this point in the history