Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(kubernetes): do not fail to deploy List kinds (e.g. ConfigMapList) #4501

Merged
merged 2 commits into from Jun 1, 2023
Merged

fix(kubernetes): do not fail to deploy List kinds (e.g. ConfigMapList) #4501

merged 2 commits into from Jun 1, 2023

Commits on May 31, 2023

  1. fix(kubernetes): do not fail to deploy List kinds (e.g. configMapList) 

    Fixes #4500

Co-authored-by: Srihas Konduru <srihas-g@users.noreply.github.com>
    @stefreak
    stefreak and Srihas Konduru committed May 31, 2023
    Configuration menu
    Copy the full SHA
    5374942 View commit details
    Browse the repository at this point in the history

  2. improvement: slightly increase defensiveness 

    Maybe the List is actually a CRD? Seems to be unlikely as other tools like Kustomize also treat kinds matching `*List` as lists.
But add a better error message here if items contains something unexpected just in case.

This logic is more or less equivalent to https://github.com/kubernetes-sigs/kustomize/blob/cf3e81b590ab1fd7fc8f50849535f44bfea0d355/api/resource/factory.go#L550
    @stefreak
    stefreak committed May 31, 2023
    Configuration menu
    Copy the full SHA
    0e46a7e View commit details
    Browse the repository at this point in the history