fix: don't watch project-level log files #477
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added *.log to the list of path patterns ignored by default. Previously, running `garden get status` in a project where * Another Garden command is running in watch mode, and * A service from a module at the project level (i.e. with its module config in the project-wide `garden.yml`) is deployed with hot reloading enabled, would erroneously trigger a hot reload of that service, due to the project-level `error.log` getting touched during the execution of `garden get status`. Fixes #387.
thsig
force-pushed
the
fix-get-status-bug
branch
from
88455ee
to
81c8d04
Compare
edvald
approved these changes
Jan 25, 2019
This was referenced May 25, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added
*.logto the list of path patterns ignored by default.Previously, running
garden get statusin a project whereAnother Garden command is running in watch mode, and
A service from a module at the project level (i.e. with its
module config in the project-wide
garden.yml) is deployedwith hot reloading enabled,
would erroneously trigger a hot reload of that service, due to the
project-level
error.loggetting touched during the execution ofgarden get status.Fixes #387.