-
Notifications
You must be signed in to change notification settings - Fork 267
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: added docs for config resolution flow #4978
Conversation
b3f2d1e
to
abb7255
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you! 👍
I've left a few comments, please check.
abb7255
to
94316a9
Compare
Should be good to go now—I addressed most of the comments (and skipped some of them). Thanks for reading through this! |
94316a9
to
de2ab48
Compare
This is great! I see myself looking this up multiple times. Out of scope for this PR but I'm wondering if we should collect all these in a single place, e.g. a top-level dir called (I know co-locating is a good thing in general, but maybe high level architectural docs like this are an exception.) |
60b643b
to
c8d0fff
Compare
Good idea! I'll do that. |
This should be useful for contributors when debugging config resolution issues or adding features relating to templating (at least to get a high-level orientation and figure out where to start).
c8d0fff
to
80176fd
Compare
I read this through again and made a couple of edits and clarifications. Should be good to go. |
@thsig my only critique is I'm not sure I understand why we're embedding docs in |
Yeah, makes sense. I've moved these to |
7bd4497
to
d41ea00
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I made one suggestion but this otherwise looks like a fantastic resource for folks looking to understand config resolution.
What this PR does / why we need it:
This should be useful for contributors when debugging config resolution issues or adding features relating to templating (at least to get a high-level orientation and figure out where to start).