Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: avoid crash during kubectl retry #5098

Merged
merged 2 commits into from
Sep 16, 2023
Merged

fix: avoid crash during kubectl retry #5098

merged 2 commits into from
Sep 16, 2023

Commits on Sep 15, 2023

  1. fix: use forceRetry when using requestWithRetry with kubectl command 

    This is needed because toKubernetesError does not know (and should not
know) how to deal with a ChildProcessError.

When using requestWithRetry for anything other than Kubernetes requests,
forceRetry needs to be true.

It's questionable if we should use requestWithRetry at all or we should
rather resort to pRetry directly.
    @stefreak
    stefreak committed Sep 15, 2023
    Configuration menu
    Copy the full SHA
    f5fb8f8 View commit details
    Browse the repository at this point in the history

  2. fix: use correct manifest loglevel in the error message

    @stefreak
    stefreak committed Sep 15, 2023
    Configuration menu
    Copy the full SHA
    139b924 View commit details
    Browse the repository at this point in the history