fix: add fsevents as a dependency #5133
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mkhq
force-pushed
the
fix-fsevents-import
branch
from
26ada17
to
134dfc2
Compare
|
Don't we have our own version of |
Yes, honestly not sure if we need that? I've removed it since now we include as an optional dependency.
|
This reverts commit fda12f6.
We use it when packaging the macos build. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Add fsevents to the dependencies. It's loaded dynamically if the platform is darwin in core/src/watch.ts .
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer: