Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(examples): fix typo in k8s example #5337

Merged
merged 2 commits into from
Nov 14, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
3 changes: 2 additions & 1 deletion core/src/cloud/api.ts
Expand Up @@ -201,7 +201,8 @@ export class CloudApi {
/**
* Initialize the Cloud API.
*
* Returns null if the project is not configured for Garden Cloud or if the user is not logged in.
* Returns null if the user is not logged in.
*
* Throws if the user is logged in but the token is invalid and can't be refreshed.
*
* Optionally skip logging during initialization. Useful for noProject commands that need to use the class
Expand Down
3 changes: 2 additions & 1 deletion examples/k8s-deploy-shared-manifests/README.md
Expand Up @@ -19,7 +19,6 @@ type: kubernetes
name: api
source:
path: ../ # <--- We set the source path of the action to the root so that we can reference the manifest files

spec:
files:
- manifests/deployment.yaml
Expand All @@ -29,6 +28,8 @@ spec:
kind: Deploy
type: kubernetes
name: web
source:
path: ../ # <--- We set the source path of the action to the root so that we can reference the manifest files
spec:
files:
- manifests/deployment.yaml
Expand Down
Expand Up @@ -15,7 +15,7 @@ spec:
app: ${var.appName}
spec:
imagePullSecrets:
- name: ${var.imagePullSecret}
- name: ${var.imagePullSecretName}
containers:
- name: ${var.appName}
image: "${actions.build[var.appName].outputs.deployment-image-id}"
Expand Down
2 changes: 1 addition & 1 deletion examples/k8s-deploy-shared-manifests/project.garden.yml
Expand Up @@ -15,7 +15,7 @@ variables:
environments:
- name: local
variables:
imagePullSecretName: "" # <--- Not needed for local dev
imagePullSecretName: "fake-secret" # <--- Not needed for local dev
baseHostname: local.demo.garden
- name: remote
defaultNamespace: ${var.remoteEnvName}
Expand Down