feat: respect NO_COLOR env var #5451
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A quick fix to ensure Garden respects the NO_COLOR env var and doesn't print colored logs if it's set. We should also this as a CLI flag but this is a start.
This was accidentally merged but not used
stefreak
approved these changes
Nov 20, 2023
shumailxyz
approved these changes
Nov 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
A quick fix to ensure Garden respects the
NO_COLORenv var and doesn't print colored logs if it's set. We should also this as a CLI flag but this is a start.A second commit also removes unused code that got accidentally left in.
Which issue(s) this PR fixes:
Fixes #2420
Special notes for your reviewer: