Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improvement(logger): use 'white' as primary color #5465

Merged
merged 1 commit into from
Nov 21, 2023

Conversation

eysi09
Copy link
Collaborator

@eysi09 eysi09 commented Nov 21, 2023

What this PR does / why we need it:

Before this commit, our primary log color was chalk.grey and people generally agree that it's too vague.

This commit changes the primary log color we've been using since we first released Garden to chalk.white for better accessibility and more fun.

In general we can make this configurable. But I figured I'd just bite the bullet.

See also discussion in: #5464

Which issue(s) this PR fixes:

Fixes #5464

Special notes for your reviewer:

Before this commit, our primary log color was chalk.grey and people
generally agree that it's too vague.

This commit changes the primary log color we've been using since we
first released Garden to chalk.white for better accessibility and more
fun.

In general we can make this configurable. But I figured I'd just bite
the bullet.

See also discussion in: #5464
@eysi09 eysi09 requested a review from a team November 21, 2023 16:39
Copy link
Contributor

@shumailxyz shumailxyz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's do this 👍

@eysi09 eysi09 added this pull request to the merge queue Nov 21, 2023
Merged via the queue into main with commit b8e232c Nov 21, 2023
45 checks passed
@eysi09 eysi09 deleted the change-primary-log-color branch November 21, 2023 17:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants