fix(core): versioning fix for remote sources #5735
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before this fix, we were including the relative path to a file from project root in the string to be hashed when calculating versions. This was problematic when linking remote sources, since the chosen name and path of the locally linked repo would be factored into the version (resulting in unwanted cache misses). This was fixed by using the relative path from the directory containing the file's parent config. For example, an action's directory should be able to be moved around or renamed without it affecting the version of that action.
vvagaytsev
previously approved these changes
Feb 15, 2024
|
There are some test failures. Likely just some trivial assertion failures because of the changed hash calculation. |
Changed the `include-exclude` test project to use actions instead of modules (we should keep incrementally doing this to prepare for deprecating modules). Also wrote a test case for the fix introduced in the previous commit.
thsig
force-pushed
the
repo-name-version-change-fix
branch
from
0523449
to
fd7ddef
Compare
vvagaytsev
approved these changes
Feb 15, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Before this fix, we were including the relative path to a file from project root in the string to be hashed when calculating versions.
This was problematic when linking remote sources, since the chosen name and path of the locally linked repo would be factored into the version (resulting in unwanted cache misses).
This was fixed by using the relative path from the directory containing the file's parent config. For example, an action's directory should be able to be moved around or renamed without it affecting the version of that action.
Which issue(s) this PR fixes:
Fixes #5501.