improvement: improve cli startup performance using v8 cache #6049
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This can speed up the core command startup time. Can be enabled by now using `GARDEN_COMPILE_CACHE=1` and is disabled by default. On my M2 mac it saves ~11-30ms when running `garden --help`
stefreak
changed the title
vvagaytsev
approved these changes
May 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use the V8 cache feature introduced in Node v22.1.0 to improve the CLI command startup time.
This feature is enabled by default, and
GARDEN_COMPILE_CACHE=0can be used if it causes a problem as escape hatch.On my M2 mac it saves ~11-30ms when running
garden --help; On CircleCI Windows runner it saves 2 seconds for each CLI command invocation, so the difference can be really significant.