Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(actions): return all outputs of an action as a json string #6067

Merged
merged 1 commit into from
May 22, 2024

Conversation

twelvemo
Copy link
Collaborator

@twelvemo twelvemo commented May 22, 2024

What this PR does / why we need it:

To make it possible to return all outputs from actions as a json string, we need to allow setting the needsExecutedOutputs to true.

When referencing ${actions.deploy.<name>.outputs} without another key outputKey is undefined which without the change in this PR will cause needsExecutedOutputs to be false. This results in ${actions.deploy.<name>.outputs} to always be an empty object.

Which issue(s) this PR fixes:

Fixes #6046

Special notes for your reviewer:
TODO:

  • Need to adjust the joi schema for outputs, so this is also documented in the reference docs.
  • Need to track down why provider outputs are returned as plain object, while action outputs are returned as json string.

@twelvemo twelvemo requested a review from vvagaytsev May 22, 2024 15:50
@vvagaytsev vvagaytsev added this pull request to the merge queue May 22, 2024
Merged via the queue into main with commit 7c60c6b May 22, 2024
40 checks passed
@vvagaytsev vvagaytsev deleted the actions-return-all-outputs branch May 22, 2024 18:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEATURE]: Return outputs from terraform as json string
2 participants