Remote ingress update docs #812
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
edvald
reviewed
Jun 3, 2019
docs/using-garden/remote-clusters.md
Outdated
| @@ -33,7 +33,7 @@ project: | |||
|
|
|||
| ### Ingress, TLS and DNS | |||
|
|
|||
| The cluster needs to have a configured [nginx ingress controller](https://github.com/kubernetes/ingress-nginx). | |||
| By default, Garden will not install an ingress controller for remote environments. This can be toggled by setting the [`setupIngressController` flag](../reference/providers/kubernetes#environments.providers.setupingresscontroller) to `nginx`. Alternatively, you can configure your own [nginx ingress controller](https://github.com/kubernetes/ingress-nginx). | |||
There was a problem hiding this comment.
I think instead of suggesting just nginx we could mention others like Traefik, Ambassador, Istio, and link to our example projects if applicable.
|
This needs rebasing off master, plus I had one small comment. |
eysi09
force-pushed
the
remote-ingress-update-docs
branch
2 times, most recently
from
6912893
to
cade1e8
Compare
|
I've rebased and addressed the comment. |
edvald
approved these changes
Jun 6, 2019
eysi09
force-pushed
the
remote-ingress-update-docs
branch
from
cade1e8
to
95fd1a0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#811 needs to be merged first to avoid link check failing.