Update UpdateChecker.kt: Add delay to reduce 429 Too Many Requests. #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add delay to reduce 429 Too Many Requests. This might be a hacky way, but I'd really like a delay in updates if it means my whole library actually gets updated.
|
What's weird is I've already added random delays here and here. I check for an IOException caused by http errors, wait 2-5 seconds, then retry. But I guess if you instantly send a bunch of requests to itch.io then it will just reject you for a while anyway? Ideally this should get more testing and maybe could be solved in a more elegant way (instead of retrying with random delay, move the game to the back of the queue, maybe). But for now I'll just merge this, thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This might be a hacky way, but I'd really like a delay in updates if it means my whole library actually gets updated.
Hi, first off, I want to say I really like your app. I've added a delay between update calls to reduce the amount of 429 "Too Many Requests" errors.
I tested this a bit on an emulator with around 18 games installed and refreshing. And it had a good result, I got no 429's. While without the delay, I'd get around 3 or more. However, this amount only increases further the more games you have downloaded.