Even more tests #56
Even more tests #56
Conversation
src/components/Header/Header.test.js
Outdated
| }); | ||
|
|
||
| it("the hamburger button toggles the menu", async () => { | ||
| act(() => { |
There was a problem hiding this comment.
could try and put this act resize function in its own function since we're writing it twice - (and probably will use it more)
There was a problem hiding this comment.
Thanks for the feedback! Pushing this up right now. I extracted it from the tests but left it in the file (with an export), since at the moment I'm not sure where its best long-term home would be.
src/hooks/useUser.js
Outdated
| @@ -1,10 +1,12 @@ | |||
| import { useQuery } from '@apollo/client'; | |||
| import { CURRENT_USER_QUERY } from 'queries' | |||
|
|
|||
| export const useUser = () => { | |||
| function useUser() { | |||
There was a problem hiding this comment.
just something to think about, could maybe do something like:
const { data, loading } = useQuery(CURRENT_USER_QUERY);
if (!loading) {
const {currentUser} = data;
return currentUser;
}also feel like useUser is a little weird tongue twister of a name lol, maybe we can do useCurrentUser?
There was a problem hiding this comment.
Good thinking! Changed the name and updated all imports. Refactored as suggested here adding in a possible error state as well:
if (!loading && !error)
Description:
Added more tests for Header, GardenList, Profile, and App components, and did some slight reformatting to standardize user flow (updated App to use useUser hook rather than getToken to determine routing).
Tests:
Most changes are made to tests themselves, but other changes are addressed by tests.
Checklist:
Please put an x in each box that you have completed