Skip to content
This repository has been archived by the owner on Jul 25, 2022. It is now read-only.

Read kubeconfig from garden cluster #107

Merged
merged 1 commit into from
Aug 7, 2019
Merged

Read kubeconfig from garden cluster #107

merged 1 commit into from
Aug 7, 2019

Conversation

ialidzhikov
Copy link
Contributor

@ialidzhikov ialidzhikov commented Aug 4, 2019 •
edited
Loading

What this PR does / why we need it:

  • Read kubeconfig from garden cluster (not seed)
  • go get github.com/gardener/gardener@0.27.1

Which issue(s) this PR fixes:
Ref #73

Special notes for your reviewer:
Depends on #105.

Release note:

NONE

@gardener-robot-ci-1 gardener-robot-ci-1 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Aug 4, 2019
DockToFuture
DockToFuture reviewed Aug 5, 2019
View reviewed changes
Copy link
Contributor

@DockToFuture DockToFuture left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm but use here as well project names instead of namespaces for projects.

@ialidzhikov ialidzhikov force-pushed the enh/read-kubeconfig-from-garden branch from a270dc1 to b52222e Compare August 7, 2019 08:04
@ialidzhikov ialidzhikov added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Aug 7, 2019
@gardener-robot-ci-1 gardener-robot-ci-1 added needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Aug 7, 2019
@ialidzhikov ialidzhikov force-pushed the enh/read-kubeconfig-from-garden branch from b52222e to 054d064 Compare August 7, 2019 08:13
@ialidzhikov ialidzhikov added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Aug 7, 2019
DockToFuture
DockToFuture approved these changes Aug 7, 2019
View reviewed changes
Copy link
Contributor

@DockToFuture DockToFuture left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@DockToFuture DockToFuture merged commit 5d28277 into gardener-attic:master Aug 7, 2019
@vpnachev vpnachev mentioned this pull request Aug 14, 2019
Merged
@DockToFuture DockToFuture mentioned this pull request Aug 14, 2019
Closed
2 tasks
@ialidzhikov ialidzhikov deleted the enh/read-kubeconfig-from-garden branch August 16, 2019 08:16
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@DockToFuture DockToFuture DockToFuture approved these changes

@vpnachev vpnachev Awaiting requested review from vpnachev

Assignees
No one assigned
Labels
reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ialidzhikov @DockToFuture @gardener-robot-ci-1