This repository has been archived by the owner on Apr 7, 2020. It is now read-only.
Change monitoring ConfigMaps' syntax of provider-specific components #344
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rfranzke
previously approved these changes
Sep 27, 2019
rfranzke
added
the
reviewed/ok-to-test
gardener-robot-ci-1
added
needs/ok-to-test
wyb1
suggested changes
Sep 27, 2019
...ed-controlplane/charts/alicloud-cloud-controller-manager/templates/configmap-monitoring.yaml
Show resolved
Hide resolved
svetlinas
force-pushed
the
fix-monitoring-configmaps
branch
from
1c31a88
to
87ba948
Compare
rfranzke
added
the
reviewed/ok-to-test
gardener-robot-ci-3
removed
the
reviewed/ok-to-test
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Change monitoring ConfigMaps' syntax of provider-specific components to be easily integrated with Gardener's Prometheus' configurations and Grafana's dashboards.
Which issue(s) this PR fixes:
Fixes #gardener/gardener#1351
Release note: