Skip to content
This repository has been archived by the owner on Apr 7, 2020. It is now read-only.

Protect machine CRDs from accidential deletion #625

Merged
merged 1 commit into from Apr 2, 2020
Merged

Protect machine CRDs from accidential deletion #625

merged 1 commit into from Apr 2, 2020

Conversation

rfranzke
Copy link
Contributor

@rfranzke rfranzke commented Mar 20, 2020 •
edited by ialidzhikov

What this PR does / why we need it:
This PR adds the deletion protection labels to the machine CRDs in order to prevent them from accidental deletion.

Special notes for your reviewer:
✅ Depends on merge of gardener/gardener#2066 and revendoring

Release note:

The `machine.sapcloud.io` CRDs applied by the `./pkg/controller/worker` package do now get a protection label for accidental deletion. See also: https://github.com/gardener/gardener/pull/2066

@gardener-robot-ci-1 gardener-robot-ci-1 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Mar 20, 2020
timebertt
timebertt reviewed Mar 20, 2020
View reviewed changes
Copy link
Contributor

@timebertt timebertt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@rfranzke rfranzke force-pushed the feature/deletion-protection branch from 3e1aa1d to c261063 Compare April 2, 2020 10:41
@gardener-robot-ci-2 gardener-robot-ci-2 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Apr 2, 2020
@rfranzke rfranzke marked this pull request as ready for review April 2, 2020 10:41
@rfranzke rfranzke requested a review from a team as a code owner April 2, 2020 10:41
@rfranzke rfranzke added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Apr 2, 2020
@gardener-robot-ci-2 gardener-robot-ci-2 removed the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Apr 2, 2020
ialidzhikov
ialidzhikov approved these changes Apr 2, 2020
View reviewed changes
Copy link
Contributor

@ialidzhikov ialidzhikov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@rfranzke rfranzke merged commit 88d7a59 into gardener-attic:master Apr 2, 2020
@rfranzke rfranzke deleted the feature/deletion-protection branch April 2, 2020 13:02
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ialidzhikov ialidzhikov ialidzhikov approved these changes

@timebertt timebertt timebertt approved these changes

Assignees
No one assigned
Labels
needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@rfranzke @ialidzhikov @timebertt @gardener-robot-ci-1 @gardener-robot-ci-2