This repository has been archived by the owner on Nov 9, 2022. It is now read-only.
Fix discovery rate limits #112
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gardener-robot
added
area/robustness
gardener-robot-ci-1
added
reviewed/ok-to-test
rfranzke
reviewed
Feb 18, 2021
| @@ -90,7 +90,7 @@ func (o *SourceClientOptions) Completed() *SourceClientConfig { | |||
|
|
|||
| func getSourceScheme() *runtime.Scheme { | |||
| scheme := runtime.NewScheme() | |||
| utilruntime.Must(corev1.AddToScheme(scheme)) | |||
| utilruntime.Must(kubernetesscheme.AddToScheme(scheme)) | |||
There was a problem hiding this comment.
FYI: We have seen issues with event reporting for Lease objects now that GRM uses configmapsleases as default leader election resource lock. We decided that we can simply add all Kubernetes APIs to our source scheme here.
gardener-robot
added
reviewed/lgtm
timebertt
added a commit
that referenced
this pull request
Feb 18, 2021
[release-v0.21] Cherry-pick of #112: Fix discovery rate limits
gardener-robot
added
priority/3
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
How to categorize this PR?
/area robustness
/kind bug
/priority normal
What this PR does / why we need it:
Follow-up on #111.
We observed many throttled discovery calls (see #109), because the target REST mapper was rediscovering resources with a rate of
1 / 10s, but the default QPS/burst settings of5 / 100were used in the discovery client.For grm's targeting shoot clusters, grm tries to do a rediscovery in every reconciliation loop because it checks if any HVPA resources are present, that scale resources applied by grm.
This becomes a problem in conjunction with unavailable
APIServices(the discovery client will run into the default timeout of32s) and the reconciliation timeouts added in #102. I.e. if there are unavailableAPIServicesthe throttled discovery call will take long enough to exceed the reconciliations timeout, giving the actual reconciliation no chance to do its work.Additionally this PR:
coreschemeWhich issue(s) this PR fixes:
Fixes #109
Special notes for your reviewer:
Release note: