Skip to content
This repository has been archived by the owner on Nov 9, 2022. It is now read-only.

Add error message to condition when apply/delete fails #43

Merged

Conversation

timebertt
Copy link
Contributor

What this PR does / why we need it:
This PR adds an error message containing all the errors that occurred while applying/deleting managed objects to the ResourcesApplied condition of the ManagedResource.

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

Release note:

The `ResourcesApplied` condition of `ManagedResource`s now includes all errors, that occurred while applying/deleting managed objects if there were any.

@timebertt timebertt requested a review from a team as a code owner March 30, 2020 10:54
@gardener-robot-ci-3 gardener-robot-ci-3 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Mar 30, 2020
@gardener-robot-ci-2 gardener-robot-ci-2 added needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Mar 30, 2020
@timebertt timebertt merged commit aac5ee5 into gardener-attic:master Apr 2, 2020
@timebertt timebertt deleted the enh/condition-error-message branch April 2, 2020 06:40
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants