Skip to content
This repository has been archived by the owner on Nov 9, 2022. It is now read-only.

Inject labels into VolumeClaimTemplates of StatefulSets #49

Merged

Conversation

timebertt
Copy link
Contributor

What this PR does / why we need it:
This PR extends the injectLabels functionality of grm to also inject the specified labels into .spec.volumenClaimTemplates of StatefulSets. Though, it only does so for newly created StatefulSets as the field is immutable.

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

Release note:

`gardener-resource-manager` now also injects labels specified in `.spec.injectLabels` into the `.spec.volumeClaimTemplates` of new StatefulSets.

@timebertt timebertt requested a review from a team as a code owner April 24, 2020 12:18
@gardener-robot-ci-1 gardener-robot-ci-1 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Apr 24, 2020
@gardener-robot-ci-2 gardener-robot-ci-2 added needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Apr 24, 2020
Copy link
Contributor

@rfranzke rfranzke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

pkg/controller/managedresources/controller_test.go Outdated Show resolved Hide resolved
@timebertt timebertt force-pushed the enh/inject-labels-volume-claims branch from a6d7886 to cfecea8 Compare April 28, 2020 07:57
@gardener-robot-ci-2 gardener-robot-ci-2 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Apr 28, 2020
@gardener-robot-ci-1 gardener-robot-ci-1 removed the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Apr 28, 2020
@rfranzke rfranzke merged commit 7bed143 into gardener-attic:master Apr 28, 2020
@timebertt timebertt deleted the enh/inject-labels-volume-claims branch April 28, 2020 09:48
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants